BUG: Fix unpickling of string dtypes of legacy pandas versions #61770
+14
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Liam3851
changed the title
jorisvandenbossche
added
Bug
Strings
jorisvandenbossche
approved these changes
Jul 4, 2025
There was a problem hiding this comment.
@Liam3851 thanks a lot for the bug report and the fix!
Looks perfect, and thanks for adding legacy data (we should probably also add some data for 2.0-2.2 ..).
Can you add a note in the doc/source/whatsnew/v2.3.1.rst file? Because we will want to backport this fix
| @@ -218,6 +220,10 @@ def __eq__(self, other: object) -> bool: | |||
| return self.storage == other.storage and self.na_value is other.na_value | |||
| return False | |||
|
|
|||
| def __setstate__(self, state: MutableMapping[str, Any]) -> None: | |||
| self.storage = state.pop("storage", "python") | |||
There was a problem hiding this comment.
Suggested change
| self.storage = state.pop("storage", "python") | |
| # back-compat for pandas < 2.3, where na_value did not yet exist | |
| self.storage = state.pop("storage", "python") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.